Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP8 support #83

Merged
merged 1 commit into from
Dec 15, 2020
Merged

PHP8 support #83

merged 1 commit into from
Dec 15, 2020
+29 −9

Conversation

canvural
Copy link
Contributor

This PR:

  • Fixes Support PHP 8 #81
  • Removes php-cs-fixer from composer.json and downloads phar on launch
  • Fixes deprecated PHPUnit methods

cebe
cebe reviewed Dec 14, 2020
View reviewed changes
Makefile Outdated
@@ -38,6 +38,8 @@ schemas/openapi-v3.0.json: vendor/oai/openapi-specification/schemas/v3.0/schema.
schemas/openapi-v3.0.yaml: vendor/oai/openapi-specification/schemas/v3.0/schema.yaml
cp $< $@

php-cs-fixer.phar:
wget https://github.com/FriendsOfPHP/PHP-CS-Fixer/releases/download/v2.16.7/php-cs-fixer.phar && chmod 777 php-cs-fixer.phar
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
wget https://github.com/FriendsOfPHP/PHP-CS-Fixer/releases/download/v2.16.7/php-cs-fixer.phar && chmod 777 php-cs-fixer.phar
wget https://github.com/FriendsOfPHP/PHP-CS-Fixer/releases/download/v2.16.7/php-cs-fixer.phar && chmod +x php-cs-fixer.phar

@cebe cebe added this to the 1.5.0 milestone Dec 14, 2020
@cebe
Copy link
Owner

cebe commented Dec 14, 2020

Thanks for these changes. Tests are failing, seems there is another case related to assertInternalType() method. Do you have the time to fix these?

@cebe cebe self-assigned this Dec 14, 2020
@cebe cebe mentioned this pull request Dec 14, 2020
Closed
@canvural
Copy link
Contributor Author

canvural commented Dec 14, 2020 •
edited
Loading

@cebe Updated the PR 👍 Locally tests are failing for ReferenceTest::testTransitiveReferenceOverTwoFiles But I'm thinking this is because of the latest changes to master?

@cebe
Copy link
Owner

cebe commented Dec 15, 2020

Thank you! I'll check that.

@cebe
Copy link
Owner

cebe commented Dec 15, 2020

whatever happened to travis, their open source tests are having a large backlog, can't check the tests for different systems this way :-/

@canvural
Copy link
Contributor Author

Basically, travis-ci.org is shutting down soon. And now there will be no free builds for OSS projects. 🤷‍♂️ If I understood correctly.

@cebe
Copy link
Owner

cebe commented Dec 15, 2020

seems like that, I'm implementing github actions right now.

cebe added a commit that referenced this pull request Dec 15, 2020
@cebe
Merge branch 'php8' PR #83
e2cd7ab 
* php8:
  improved types for phpstan
  PHP8 support
@cebe cebe merged commit 696bfd0 into cebe:master Dec 15, 2020
@cebe
Copy link
Owner

cebe commented Dec 15, 2020

Merged your changes, will clean up the build on master. Thank you!

@canvural
Copy link
Contributor Author

Thank you @cebe

@cebe
Copy link
Owner

cebe commented Dec 15, 2020

Tests are failing here due to a symfony bug 😆 symfony/symfony#39521

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cebe cebe cebe left review comments

Assignees

@cebe cebe

Labels
None yet
Projects
None yet
Milestone
1.5.0
Development

Successfully merging this pull request may close these issues.

Support PHP 8
2 participants
@canvural @cebe